map RG #978
map RG #978
Conversation
|
/run pipeline |
tests/pr_test.go
Outdated
| "prefix": options.Prefix, | ||
| "bucket_name": "test", | ||
| "bucket_name": "test", | ||
| "resource_group": resourceGroup, |
There was a problem hiding this comment.
resource_group is not the name of the input, thats just the display name in ibm_catalog.json. The input is called existing_resource_group_name
tests/pr_test.go
Outdated
| "prefix": options.Prefix, | ||
| "bucket_name": "test", | ||
| "bucket_name": "test", | ||
| "resource_group": resourceGroup, |
ibm_catalog.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "key": "resource_group", |
There was a problem hiding this comment.
Not following why you are adding this virtual input? You should be mapping the existing_resource_group_name input down
There was a problem hiding this comment.
if your starting point is buckets there is no RG, so we need a virtual for it. For consistency I will update it to existing_resource_group_name with displayname
There was a problem hiding this comment.
ahh got it - just for buckets yes
ibm_catalog.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "key": "resource_group", |
ibm_catalog.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "key": "resource_group", |
ibm_catalog.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "key": "resource_group", |
There was a problem hiding this comment.
I can update these but they are virtual inputs that would get a display name of resource_group so I skipped calling them existing
There was a problem hiding this comment.
why do we have a virtual input at all? #978 (comment)
There was a problem hiding this comment.
Oh and also you need to change the default value of existing_resource_group_name in the terraform code. It should now default to "Default" and I think remove the sentence "If not provided the default resource group will be used." from the description like I did in PR109
|
/run pipeline |
|
🎉 This PR is included in version 10.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
mapping resource group down to dependencies
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers